Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect webp, libzip, libedit, bzip2 #21

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

salzig
Copy link
Contributor

@salzig salzig commented Jul 25, 2019

additionally to other libraries, also detect webp, libzip, libedit, bzip2 and configure accordingly.

@salzig
Copy link
Contributor Author

salzig commented Jul 31, 2019

@odarriba any feedback on this?

@odarriba
Copy link
Contributor

First of all, sorry for the delay: there have been some really busy months.

I like the idea, but it will be great to detect them also on Linux. Is there any chance to add those libraries discovery for linux?

@salzig
Copy link
Contributor Author

salzig commented Nov 3, 2019

I'm sure it would be possible, but i created this merge request because of the existing problem on mac (#8). Should the detection for linux be included in this merge request?

@odarriba
Copy link
Contributor

odarriba commented Nov 6, 2019

@salzig I think that could be addressed on other PR if needed.

Merging, thanks for the PR! ❤️

@odarriba odarriba merged commit cb81fc4 into asdf-community:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants